fix: link to repo root instead of 404ing /stargazers page#8756
Open
katspaugh wants to merge 1 commit into
Open
fix: link to repo root instead of 404ing /stargazers page#8756katspaugh wants to merge 1 commit into
katspaugh wants to merge 1 commit into
Conversation
GitHub's stargazers page returns 404 for users without repo write access, so the web-fallback star flow in the landing screen and General settings sent most users to a broken link. Point both at the repo root instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated GitHub star web-fallback handling in the landing and general support components. Both flows now replace the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/stablyai/orca/stargazers, which returns a 404 for anyone without write access to the repo.https://github.com/stablyai/orca), which works for everyone and still lets the user find and click the Star button themselves.No visual change — same button/label/copy, only the destination URL differs.
Code review summary
window.api.shell.openUrl, unrelated to the SSH/remote git workflow.Test plan
pnpm lintpnpm typecheckpnpm test(full suite: 29614 passed, 55 skipped; 4 pre-existing failures inconfig/scripts/publish-complete-draft-releases.test.mjsandconfig/scripts/release-rc-history.test.mjsare unrelated to this change — caused by a localtag.gpgsign=truegit config making lightweightgit tagcalls fail in those scripts' test harness, not touching any file changed here)pnpm buildhttps://github.com/stablyai/orca/stargazersreturns 404 andhttps://github.com/stablyai/orcareturns 200🤖 Generated with Claude Code